Skip to content

Comments

Borderfall repath#5222

Closed
Bloo4420 wants to merge 5 commits intoMonkestation:mainfrom
Bloo4420:rosewoodfixes
Closed

Borderfall repath#5222
Bloo4420 wants to merge 5 commits intoMonkestation:mainfrom
Bloo4420:rosewoodfixes

Conversation

@Bloo4420
Copy link

@Bloo4420 Bloo4420 commented Feb 12, 2026 •
edited
Loading

About The Pull Request

Varedited cobble edges were previously used for the borderfall objects used on stage edges and other areas, these were changed with #4767 (I believe) leading to them breaking on some maps. This PR updates the paths for all .dmm that use the deprecated version.

Why It's Good For The Game

Clarity and expected items showing up in maps.

Changelog

🆑
map: Repathed all borderfall objects
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions bot added the Mapping You changed a map file, thank you for your tiles. May require additional approval. label Feb 12, 2026
@github-actions github-actions bot requested a review from Draggeru February 12, 2026 02:33
@CheffieGithub
Copy link
Collaborator

CheffieGithub commented Feb 12, 2026 •
edited
Loading

/obj/effect/decal/cobbleedge{icon_state = "borderfall"} : /obj/effect/decal/borderfall{@OLD} update paths

@Bloo4420
Copy link
Author

Bloo4420 commented Feb 13, 2026

/obj/effect/decal/cobbleedge{icon_state = "borderfall"} : /obj/effect/decal/borderfall{@OLD} update paths

It isn't recognizing /obj/effect/decal/cobbleedge as a valid path. I'm sure I am just misunderstanding. This should replace all of the deprecated, edited cobbleedges with the proper borderfall object, right?

@CheffieGithub
Copy link
Collaborator

CheffieGithub commented Feb 13, 2026

Yes but its an update paths script

@github-actions github-actions bot added the MERGE CONFLICT This PR has conflicting changes with the main branch and can't be merged label Feb 21, 2026
@github-actions github-actions bot removed the MERGE CONFLICT This PR has conflicting changes with the main branch and can't be merged label Feb 21, 2026
@Bloo4420
Copy link
Author

Bloo4420 commented Feb 21, 2026

Yes but its an update paths script

I smartened up and read the documentation on this. Should be good to go now. Thanks Cheffie

@Bloo4420 Bloo4420 changed the title Fix borderfall objects on Rosewood Borderfall repath Feb 21, 2026
@CheffieGithub
Copy link
Collaborator

CheffieGithub commented Feb 22, 2026

I forgot to put skip icon_state in it :(

@Bloo4420
Copy link
Author

Bloo4420 commented Feb 22, 2026

lol I can still do it! I wasn’t entirely sure if that mattered since the icon_state is teeeechnically still the same. No worries tho

@Bloo4420
Copy link
Author

Bloo4420 commented Feb 24, 2026

Was easier to just redo this from a fresh branch. #5381

@Bloo4420 Bloo4420 closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Draggeru Draggeru Awaiting requested review from Draggeru

Assignees

No one assigned

Labels

Mapping You changed a map file, thank you for your tiles. May require additional approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bloo4420 @CheffieGithub